Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keiko output context data #671

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Keiko output context data #671

merged 3 commits into from
Apr 5, 2023

Conversation

ammar92
Copy link
Contributor

@ammar92 ammar92 commented Apr 5, 2023

Changes

Implemented the feature that also outputs the used input data for generating the report. There's also some cleanup in the settings.

Issue ticket number and link

Solves #666

Proof

image

Extra instructions for others

Set the environment variable KEIKO_DEBUG to True

Checklist for author(s):

  • All the commits in this PR are properly PGP-signed and verified;
  • This PR comes from a feature or hotfix branch, in line with our git branching strategy;
  • This PR is "bite-sized" and only focuses on a single issue, problem, or feature;
  • I am not reinventing the wheel: there is no high-quality library that already has this feature;
  • I have changed the example .env files if I added, removed, or changed any config options, and I have informed others that they need to modify their .env files if required;
  • I have performed a self-review of my own code;
  • I have commented my code, particularly in hard-to-understand areas;
  • I have made corresponding changes to the documentation, if necessary;
  • I have written unit, integration, and end-to-end tests for the change that I made;

If a non-trivial PR:

  • This PR is part of a milestone and has appropriate labels;
  • This PR is properly linked to the project board (either directly or via an issue);
  • I have added screenshots or some other proof that my code does what it is supposed to do;
## Checklist for functional reviewer(s):
- [ ] If a non-trivial PR: This PR is properly linked to an issue on the project board;
- [ ] I have checked out this branch, and successfully ran `make kat`;
- [ ] I have ran `make test-rf` and all end-to-end Robot Framework tests pass;
- [ ] I confirmed that the PR's advertised `feature` or `hotfix` works as intended;
- [ ] I confirmed that there are no unintended functional regressions in this branch;

### What works:
* _bullet point + screenshot (if useful) per tested functionality_

### What doesn't work:
* _bullet point + screenshot (if useful) per tested functionality_

### Bug or feature?:
* _bullet point + screenshot (if useful) if it is unclear whether something is a bug or an intended feature._

## Checklist for code reviewer(s):
- [ ] The code passes the CI tests and linters;
- [ ] The code does not bypass authentication or security mechanisms;
- [ ] The code does not introduce any dependency on a library that has not been properly vetted;
- [ ] The code does not violate Model-View-Template and our other architectural principles;
- [ ] The code contains docstrings, comments, and documentation where needed;
- [ ] The code prioritizes readability over performance where appropriate;
- [ ] The code conforms to our agreed coding standards.

@ammar92 ammar92 added the keiko Issues related to keiko label Apr 5, 2023
@ammar92 ammar92 marked this pull request as ready for review April 5, 2023 13:20
@ammar92 ammar92 requested a review from a team as a code owner April 5, 2023 13:20
@ammar92 ammar92 mentioned this pull request Apr 5, 2023
Closed
@ammar92 ammar92 linked an issue Apr 5, 2023 that may be closed by this pull request
Export report input data #666
Closed
@underdarknl underdarknl merged commit 04e3047 into main Apr 5, 2023
@underdarknl underdarknl deleted the feature/keiko-output-context-data branch April 5, 2023 13:59
@ammar92 ammar92 restored the feature/keiko-output-context-data branch April 5, 2023 19:31
@ammar92 ammar92 deleted the feature/keiko-output-context-data branch April 5, 2023 19:32
@praseodym praseodym mentioned this pull request Apr 6, 2023
Closed
jpbruinsslot added a commit that referenced this pull request Apr 11, 2023
@jpbruinsslot
Merge branch 'main' into fix/mula-db-disconnect
c20a05f 
* main:
  Add new xtdb-http-multinode version to 1.7 release notes (#692)
  Fix pdflatex crash when there are underscores (#690)
  fix crisis room when no description (#686)
  Appropriate min_scan_level for bits (#684)
  Handle errors from Octopoes connector (#647)
  Translate Dutch images in docs to English (#128)
  Don't set KAT_VERSION by default in .env-dist (#629)
  Feature/no bits without clearence (#645)
  Add missing migration and unit test for missing migrations (#677)
  Use `unless-stopped` Docker restart policy (#683)
  Update to xtdb-http-multinode v1.0.4 (#681)
  Remove unused SCHEDULER_DSP_INTERVAL and SCHEDULER_DSP_BROKER_URL env vars (#633)
  the latest version of nuclei updated the json-lines param (#664)
  Add MutedFinding OOI and filter them in report (#670)
  Fix djLint T001, T002, T003, T032 (#672)
  Keiko output context data (#671)
jpbruinsslot added a commit that referenced this pull request Apr 11, 2023
@jpbruinsslot
Merge branch 'main' into feature/octopoes/filter-random-endpoint
672236b 
* main: (41 commits)
  Bump pre-commit from 3.2.1 to 3.2.2 (#693)
  Add new xtdb-http-multinode version to 1.7 release notes (#692)
  Fix pdflatex crash when there are underscores (#690)
  fix crisis room when no description (#686)
  Appropriate min_scan_level for bits (#684)
  Handle errors from Octopoes connector (#647)
  Translate Dutch images in docs to English (#128)
  Don't set KAT_VERSION by default in .env-dist (#629)
  Feature/no bits without clearence (#645)
  Add missing migration and unit test for missing migrations (#677)
  Use `unless-stopped` Docker restart policy (#683)
  Update to xtdb-http-multinode v1.0.4 (#681)
  Remove unused SCHEDULER_DSP_INTERVAL and SCHEDULER_DSP_BROKER_URL env vars (#633)
  the latest version of nuclei updated the json-lines param (#664)
  Add MutedFinding OOI and filter them in report (#670)
  Fix djLint T001, T002, T003, T032 (#672)
  Keiko output context data (#671)
  Log pdflatex output on error (#667)
  Add djLint for Rocky templates (#626)
  Fix Keiko report downloads on uWSGI (#657)
  ...
jpbruinsslot added a commit that referenced this pull request Apr 11, 2023
@jpbruinsslot
Merge branch 'main' into chore/refactor-normalizer
c4ace52 
* main: (54 commits)
  Final djLint fixes (#701)
  Bump pre-commit from 3.2.1 to 3.2.2 (#693)
  Add new xtdb-http-multinode version to 1.7 release notes (#692)
  Fix pdflatex crash when there are underscores (#690)
  fix crisis room when no description (#686)
  Appropriate min_scan_level for bits (#684)
  Handle errors from Octopoes connector (#647)
  Translate Dutch images in docs to English (#128)
  Don't set KAT_VERSION by default in .env-dist (#629)
  Feature/no bits without clearence (#645)
  Add missing migration and unit test for missing migrations (#677)
  Use `unless-stopped` Docker restart policy (#683)
  Update to xtdb-http-multinode v1.0.4 (#681)
  Remove unused SCHEDULER_DSP_INTERVAL and SCHEDULER_DSP_BROKER_URL env vars (#633)
  the latest version of nuclei updated the json-lines param (#664)
  Add MutedFinding OOI and filter them in report (#670)
  Fix djLint T001, T002, T003, T032 (#672)
  Keiko output context data (#671)
  Log pdflatex output on error (#667)
  Add djLint for Rocky templates (#626)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underdarknl underdarknl underdarknl approved these changes

@praseodym praseodym praseodym approved these changes

Assignees
No one assigned
Labels
keiko Issues related to keiko
Projects
KAT
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export report input data
3 participants
@ammar92 @praseodym @underdarknl